Keep HBO stats equivalent node information in NULL skew optimizer#25466
Merged
feilong-liu merged 1 commit intoprestodb:masterfrom Jul 5, 2025
Merged
Keep HBO stats equivalent node information in NULL skew optimizer#25466feilong-liu merged 1 commit intoprestodb:masterfrom
feilong-liu merged 1 commit intoprestodb:masterfrom
Conversation
jaystarshot
reviewed
Jul 1, 2025
|
|
||
| ProjectNode newLeft = new ProjectNode(rewrittenLeft.getSourceLocation(), planNodeIdAllocator.getNextId(), rewrittenLeft, leftAssignments.build(), LOCAL); | ||
| ProjectNode newRight = new ProjectNode(rewrittenRight.getSourceLocation(), planNodeIdAllocator.getNextId(), rewrittenRight, rightAssignments.build(), LOCAL); | ||
| ProjectNode newLeft = new ProjectNode(rewrittenLeft.getSourceLocation(), planNodeIdAllocator.getNextId(), joinNode.getLeft().getStatsEquivalentPlanNode(), rewrittenLeft, leftAssignments.build(), LOCAL); |
Member
There was a problem hiding this comment.
Nit: we can just do
Project newLeft = joinNode.getLeft().replaceChilren() and that will automatically set this
jaystarshot
approved these changes
Jul 1, 2025
hantangwangd
approved these changes
Jul 4, 2025
7 tasks
This was referenced Jul 24, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this NULL skew optimizer, we will add a new project node under the join node, which currently does not carry the stats equivalent node from HBO, hence lose the HBO information.
Previously I think it's fine, as the the project node adds a few more columns, i.e. new join keys which is of string type. However, in recent debug, I found that this will lead to use of inaccurate CBO stats. HBO stats may have the reported size larger than it should be, which is because of the new join keys added, however the row count is still accurate and the size is still not far away since the new join key is usually small.
In this PR I keep the stats equivalent node in HBO.
Motivation and Context
As in description
Impact
More accurate stats
Test Plan
Existing unit tests
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.